@ameliahsu I was only able to get this test to pass if I used this data which differs from what was passed in https://sentry.sentry.io/issues/6980690322 which was

{
    "sentry_app_identifier":"'sentry_app_id'",
    "target_identifier":"'72013'",
    "target_type":"'sentry_app'"
}

Do you know if the data in the Sentry issue is what's expected to be passed all the time or only sometimes? I'm not sure when we pass one versus the other, but if we set sentryAppIdentifier to "sentry_app" instead of "sentry_app_installation" (SentryAppIdentifier.SENTRY_APP_INSTALLATION_UUID) we go down a slightly different code path and set sentryAppInstallationUuid to None (code here) which leads to a SentryAppInstallation.DoesNotExist error (here).

I truly don't know if this is a bug or how it's intended to work, but it doesn't currently work if you do not pass the installation data. I did verify that even an internal unpublished sentry app has an installation object, so maybe it's intended for us to always pass that data?

@GabeVillalobos might be able to help here, i believe some existing app actions use the sentry app UUID instead of the sentry app ID, which is why we have to specify sentry_app_identifier? but we would like for all newly created actions going forward to use sentry app ID. not sure if that's why we throw an error tho 😅

Short answer here is that sentry_app_installation is some legacy data we need to migrate away from and the front end will be passing sentry_app_id for new actions. I updated the code to support both until we can run the migration so that old action with the uuid can be updated.

I copied this logic from how we do it today - in project_rule_details.py and project_rules.py we call trigger_sentry_app_action_creators_for_issues (here) which skips over the validation if there is no UI component

We only need this temporarily until we can migrate the action data to not have the installation uuid

Bug: Unhandled ValueError when converting target identifier to int

When sentry_app_identifier is SENTRY_APP_ID, the code converts target_identifier to an integer without error handling. If a user passes a non-numeric string (like a UUID) as the target_identifier, this will raise an unhandled ValueError instead of returning a proper validation error, causing a 500 error rather than a user-friendly 400 validation error.

Bug: target_identifier lacks numeric validation in schema, causing ValueError during int() conversion for non-numeric inputs.
_{Severity: CRITICAL | Confidence: High}

Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: src/sentry/notifications/notification_action/action_validation.py#L225

Potential issue: The `target_identifier` field lacks proper validation in the JSON
schema, allowing non-numeric strings to pass when `sentry_app_identifier` is
`SENTRY_APP_ID`. This leads to a `ValueError` when `int(target_identifier)` is called at
`action_validation.py:225`, causing an unhandled exception and server crash.

_{Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 3862959}